feat: cronjobs db changes #1229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
matt2e
requested review from
alecthomas,
dhanji,
wesbillman and
worstell
as code owners
matt2e
commented
Apr 11, 2024
backend/controller/controller.go
Outdated
| @@ -721,14 +721,14 @@ func (s *Service) CreateDeployment(ctx context.Context, req *connect.Request[ftl | |||
| } | |||
|
|
|||
| ingressRoutes := extractIngressRoutingEntries(req.Msg) | |||
| dname, err := s.dal.CreateDeployment(ctx, ms.Runtime.Language, module, artefacts, ingressRoutes) | |||
| dkey, err := s.dal.CreateDeployment(ctx, ms.Runtime.Language, module, artefacts, ingressRoutes, nil, time.Now()) | |||
There was a problem hiding this comment.
cronjob service will be asked for cron jobs based on the module schema here, but this is skipped as part of this smaller PR.
Full version here: https://github.com/TBD54566975/ftl/blob/matt2e%2Fcron-jobs/backend/controller/controller.go#L740
matt2e
force-pushed
the
matt2e/cron-jobs-db
branch
from
10819fa to
94330f3
Compare
alecthomas
reviewed
Apr 12, 2024
matt2e
force-pushed
the
matt2e/cron-jobs-db
branch
3 times, most recently
from
52b539c to
076522d
Compare
# Conflicts: # backend/controller/dal/dal.go
# Conflicts: # backend/controller/cronjobs/cronjobs.go # backend/controller/cronjobs/cronjobs_test.go # backend/controller/cronjobs/state.go
# Conflicts: # backend/controller/dal/dal.go
matt2e
force-pushed
the
matt2e/cron-jobs-db
branch
from
076522d to
6adbbc3
Compare
alecthomas
approved these changes
Apr 12, 2024
matt2e
added a commit
that referenced
this pull request
Apr 15, 2024
- [x] Schema changes
- [x] Module validation
- [x] Support multiple controllers using hash ring
- [x] DB indexes
- [x] Tests
- [x] CronJobs Service
- [x] cron lib
- [x] schema changes
Separating into different PRs:
- [x] cron implementation: #1194
- [x] deepcopy: #1195
- [x] metadata changes #1216
- [x] db level changes: #1229
- [ ] Afterwards: ftl-examples
- [ ] Afterwards: add event for it to show in web console
#1141
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Larger PR here: #1155